[webkit-reviews] review granted: [Bug 212618] Web Inspector: Graphics: should use the `id` (name) of the animation if it exists : [Attachment 400765] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 212618: Web Inspector: Graphics: should use the `id` (name) of the
animation if it exists
https://bugs.webkit.org/show_bug.cgi?id=212618

Attachment 400765: Patch

https://bugs.webkit.org/attachment.cgi?id=400765&action=review




--- Comment #3 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 400765
  --> https://bugs.webkit.org/attachment.cgi?id=400765
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400765&action=review

> Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js:162
> +	   }

This formatting looks wrong, but what else could we do?

> Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js:168
> +	       this._idRow.value = cssAnimationName === displayName ? null :
displayName;

I’d almost flip this so null is last.

> Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js:172
> +	       this._idRow.value = cssTransitionProperty === displayName ? null
: displayName;

Ditto.