[webkit-reviews] review granted: [Bug 202425] Stressing webkitSetPresentationMode leads to wrong inline video dimensions : [Attachment 400739] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 202425: Stressing webkitSetPresentationMode leads to wrong inline video
dimensions
https://bugs.webkit.org/show_bug.cgi?id=202425

Attachment 400739: Patch

https://bugs.webkit.org/attachment.cgi?id=400739&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 400739
  --> https://bugs.webkit.org/attachment.cgi?id=400739
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400739&action=review

> Source/WebCore/html/HTMLVideoElement.cpp:463
> +    if (!m_isChangingPresentationMode &&
!m_isEnteringOrExitingPictureInPicture)

Is there any reason to not do this check in setFullscreenMode?

> Source/WebCore/html/HTMLVideoElement.cpp:492
> +    if (mode != fullscreenMode()) {
> +	   m_isChangingPresentationMode = true;
> +	   enterFullscreen(mode);
> +    }

We also call enterFullscreen() from HTMLVideoElement::webkitEnterFullscreen,
but instead of also setting this there does it make sense to do it in
HTMLMediaElement?