[webkit-reviews] review granted: [Bug 209871] [css-flexbox] align-content should apply even when there's just a single line : [Attachment 400732] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 209871: [css-flexbox] align-content should apply even when there's just a
single line
https://bugs.webkit.org/show_bug.cgi?id=209871

Attachment 400732: Patch

https://bugs.webkit.org/attachment.cgi?id=400732&action=review




--- Comment #6 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 400732
  --> https://bugs.webkit.org/attachment.cgi?id=400732
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400732&action=review

Nice catch, thanks for the fix.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1732
>      // flex line, the line height is all the available space. For

The comment was already accurate...

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1735
> +    if (!isMultiline()) {

Nit: Could we add an ASSERT(lineContexts.size() == 1) here?