[webkit-reviews] review granted: [Bug 212355] [css-flexbox] Tables as flex items should obey the flex container sizing : [Attachment 400238] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 212355: [css-flexbox] Tables as flex items should obey the flex container
sizing
https://bugs.webkit.org/show_bug.cgi?id=212355

Attachment 400238: Patch

https://bugs.webkit.org/attachment.cgi?id=400238&action=review




--- Comment #7 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 400238
  --> https://bugs.webkit.org/attachment.cgi?id=400238
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400238&action=review

The patch looks good to me, just a minor comment inline.

> Source/WebCore/rendering/RenderTable.cpp:284
> +    // is how flexible containers flex or stretch us.

Nit: s/flexible containers/flex container/ (that's the term on the spec so I
guess it's better to use it
https://drafts.csswg.org/css-flexbox/#flex-containers).