[webkit-reviews] review granted: [Bug 215013] Clean up text layout code a bit : [Attachment 405672] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 31 16:59:01 PDT 2020


zalan <zalan at apple.com> has granted Myles C. Maxfield <mmaxfield at apple.com>'s
request for review:
Bug 215013: Clean up text layout code a bit
https://bugs.webkit.org/show_bug.cgi?id=215013

Attachment 405672: Patch

https://bugs.webkit.org/attachment.cgi?id=405672&action=review




--- Comment #4 from zalan <zalan at apple.com> ---
Comment on attachment 405672
  --> https://bugs.webkit.org/attachment.cgi?id=405672
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405672&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:1391
> +    float initialAdvance;

I always get scared when I see a non-initialized variable (I know it gets a
value eventually).


More information about the webkit-reviews mailing list