[webkit-reviews] review granted: [Bug 215038] REGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other --suite flags in safaripy : [Attachment 405750] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 215038: REGRESSION(r264766) webkitpy: newly added --suite flag conflicts
with other --suite flags in safaripy
https://bugs.webkit.org/show_bug.cgi?id=215038

Attachment 405750: Patch

https://bugs.webkit.org/attachment.cgi?id=405750&action=review




--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 405750
  --> https://bugs.webkit.org/attachment.cgi?id=405750
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405750&action=review

> Tools/Scripts/webkitpy/results/options.py:34
> +	   optparse.make_option('--' + suite_name_flag, help='Optional flag for
overriding reported suite name.', default=None),

Note that since the caller of this will be the bit using the flag, we don't
need to try anything fancy to change how we consume the flag, that's up to the
code instantiation the options.