[webkit-reviews] review granted: [Bug 214995] Log a warning to the dev console when gamepads are accessed from an insecure context : [Attachment 405735] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 214995: Log a warning to the dev console when gamepads are accessed from an
insecure context
https://bugs.webkit.org/show_bug.cgi?id=214995

Attachment 405735: Patch

https://bugs.webkit.org/attachment.cgi?id=405735&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 405735
  --> https://bugs.webkit.org/attachment.cgi?id=405735
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405735&action=review

> Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp:80
> +    RELEASE_ASSERT(domWindow);
> +    auto* document = domWindow->document();
> +    RELEASE_ASSERT(document);

These seem ... aggressive? Why not just bail?