[webkit-reviews] review granted: [Bug 215024] Re-enable NO_SMT on Catalina : [Attachment 405713] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 31 11:32:14 PDT 2020


Alexey Proskuryakov <ap at webkit.org> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 215024: Re-enable NO_SMT on Catalina
https://bugs.webkit.org/show_bug.cgi?id=215024

Attachment 405713: patch

https://bugs.webkit.org/attachment.cgi?id=405713&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 405713
  --> https://bugs.webkit.org/attachment.cgi?id=405713
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405713&action=review

> Source/JavaScriptCore/runtime/Options.cpp:235
> +#if CPU(X86_64) && (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <
110000)

I’m not sure what this does in macCatalyst case, or what we want it to do.


More information about the webkit-reviews mailing list