[webkit-reviews] review granted: [Bug 214953] validate untagArrayPtr : [Attachment 405646] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 214953: validate untagArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=214953

Attachment 405646: patch

https://bugs.webkit.org/attachment.cgi?id=405646&action=review




--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 405646
  --> https://bugs.webkit.org/attachment.cgi?id=405646
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405646&action=review

r=me with some comments.

> Source/JavaScriptCore/assembler/MacroAssemblerARM64E.h:135
> +	   TrustedImm32 shiftAmount { 64 - OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH)
};

Nit: Can you use numberOfPACBits?

> Source/JavaScriptCore/assembler/MacroAssemblerARM64E.h:137
> +	   lshift64(shiftAmount, target);
> +	   urshift64(shiftAmount, target);

I think this can probably be a single and instruction for each of the constants
we currently use.