[webkit-reviews] review granted: [Bug 214988] Update service worker if certificate info does not match when soft updating : [Attachment 405678] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 214988: Update service worker if certificate info does not match when soft
updating
https://bugs.webkit.org/show_bug.cgi?id=214988

Attachment 405678: Patch

https://bugs.webkit.org/attachment.cgi?id=405678&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 405678
  --> https://bugs.webkit.org/attachment.cgi?id=405678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405678&action=review

> Tools/TestWebKitAPI/cocoa/HTTPServer.h:49
> +    HTTPServer(std::initializer_list<std::pair<String, HTTPResponse>>,
Protocol = Protocol::Http, CertificateVerifier&& = nullptr,
RetainPtr<SecIdentityRef>&& = nullptr, const String& port = { });

port should be an Optional<uint16_t> and we should do makeString in HTTPServer
instead of String::number in the test.

> Tools/TestWebKitAPI/cocoa/HTTPServer.h:60
> +    static RetainPtr<nw_parameters_t> listenerParameters(Protocol,
CertificateVerifier&&, RetainPtr<SecIdentityRef>&& = nullptr, const String&
port = { });

Default parameters are probably unnecessary here.

> Tools/TestWebKitAPI/cocoa/HTTPServer.mm:57
> +    if (!customTestIdentity)

We only need this if protocol is not Protocol::Http.