[webkit-reviews] review granted: [Bug 214990] Added AudioBuffer Constructor : [Attachment 405693] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Clark Wang
<clark_wang at apple.com>'s request for review:
Bug 214990: Added AudioBuffer Constructor
https://bugs.webkit.org/show_bug.cgi?id=214990

Attachment 405693: Patch

https://bugs.webkit.org/attachment.cgi?id=405693&action=review




--- Comment #10 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 405693
  --> https://bugs.webkit.org/attachment.cgi?id=405693
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405693&action=review

> Source/WebCore/Modules/webaudio/AudioBuffer.cpp:55
> +ExceptionOr<Ref<AudioBuffer>> AudioBuffer::create(const AudioBufferOptions&
options)

We should try to remove the other AudioBuffer::create and just use this new one
as a follow-up patch.
That will remove some potentially duplicated code.

> Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:395
> +    return AudioBuffer::create(options);

This could probably be made as a one-liner.