[webkit-reviews] review granted: [Bug 214989] Add constructor for WaveShaperNode : [Attachment 405639] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 214989: Add constructor for WaveShaperNode
https://bugs.webkit.org/show_bug.cgi?id=214989

Attachment 405639: Patch

https://bugs.webkit.org/attachment.cgi?id=405639&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 405639
  --> https://bugs.webkit.org/attachment.cgi?id=405639
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405639&action=review

> Source/WebCore/Modules/webaudio/WaveShaperNode.cpp:40
> +ExceptionOr<Ref<WebCore::WaveShaperNode>>
WaveShaperNode::create(BaseAudioContext& context, const WaveShaperOptions
&options)

s/WebCore:://
s/WaveShaperOptions &/WaveShaperOptions&/

> Source/WebCore/Modules/webaudio/WaveShaperNode.cpp:70
> +	   result = node->setCurve(curve.get());

WTFMove

> Source/WebCore/Modules/webaudio/WaveShaperNode.cpp:89
> +ExceptionOr<void> WaveShaperNode::setCurve(RefPtr<Float32Array>&& curve)

Why &&, it does not seem we move curve inside?