[webkit-reviews] review granted: [Bug 214722] Propagating media only user gesture through Fetch ReadableStream : [Attachment 405573] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has granted  review:
Bug 214722: Propagating media only user gesture through Fetch ReadableStream
https://bugs.webkit.org/show_bug.cgi?id=214722

Attachment 405573: Patch

https://bugs.webkit.org/attachment.cgi?id=405573&action=review




--- Comment #8 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 405573
  --> https://bugs.webkit.org/attachment.cgi?id=405573
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405573&action=review

LGTM. r=me. Youenn, thanks for making the patch.

> Source/WebCore/Modules/fetch/FetchBodySource.cpp:105
> +    // We asynchronously call the callback so that any promise that got
resolved can be thened by the page before the promise got settled with user
gesture priviledge.

'thened' doesn't seem to be an English word. It's unclear to me why doing it
synchronously doesn't have the benefit.