[webkit-reviews] review granted: [Bug 214979] REGRESSION (r?): Web Inspector: Timelines: blue border below selected timeline when in edit mode : [Attachment 405642] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 214979: REGRESSION (r?): Web Inspector: Timelines: blue border below
selected timeline when in edit mode
https://bugs.webkit.org/show_bug.cgi?id=214979

Attachment 405642: Patch

https://bugs.webkit.org/attachment.cgi?id=405642&action=review




--- Comment #10 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 405642
  --> https://bugs.webkit.org/attachment.cgi?id=405642
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405642&action=review

r=me, nice!

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:115
>  .timeline-overview > .tree-outline.timelines
.item:not(.selected):not(:first-child) {

It's odd to me that the `border-top` doesn't also apply when `.selected`, as
right now there's basically no border between the selected item and the item
above it, while there is a border between the selected item and the item below
it.  I think we should also have the `border-top` set when `.selected`.