[webkit-reviews] review granted: [Bug 214366] Web Inspector: on Big Sur, match OS background, text, and border colors : [Attachment 405620] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 214366: Web Inspector: on Big Sur, match OS background, text, and border
colors
https://bugs.webkit.org/show_bug.cgi?id=214366

Attachment 405620: Patch

https://bugs.webkit.org/attachment.cgi?id=405620&action=review




--- Comment #21 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 405620
  --> https://bugs.webkit.org/attachment.cgi?id=405620
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405620&action=review

r=me, nice refactoring.  I have some comments, but most of them can be done as
followups as they are about codebase health/cohesion.

> Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css:86
>      border: 1px solid hsl(0, 0%, 78%);

While you're at it, should this change too?

> Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.css:76
>	   background-color: hsl(0, 0%, 14%);

Do we have a variable for this (and in light mode)?

> Source/WebInspectorUI/UserInterface/Views/LocalResourceOverridePopover.css:59
>      border: 1px solid hsl(0, 0%, 78%);

While you're at it, should this change too?

> Source/WebInspectorUI/UserInterface/Views/URLBreakpointPopover.css:42
>      border: 1px solid hsl(0, 0%, 78%);

While you're at it, should this change too?

> Source/WebInspectorUI/UserInterface/Views/Variables.css:378
> +    body.big-sur {

please combine this with the rule below (or move that one up here)

> Source/WebInspectorUI/UserInterface/Views/Variables.css:397
> +	   --background-color-secondary: hsl(0, 0%, 23%);
> +	   --background-color-tertiary: hsl(0, 0%, 27%);

Now that we have `--background-color-intermediate`, I feel like we should
remove these (especially since they only exist in dark mode) or at least give
them better names (and add them to light mode).