[webkit-reviews] review granted: [Bug 214905] -[WKWebsiteDataStore _renameOrigin:] needs to support IndexedDB renames : [Attachment 405623] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Sihui Liu
<sihui_liu at apple.com>'s request for review:
Bug 214905: -[WKWebsiteDataStore _renameOrigin:] needs to support IndexedDB
renames
https://bugs.webkit.org/show_bug.cgi?id=214905

Attachment 405623: Patch

https://bugs.webkit.org/attachment.cgi?id=405623&action=review




--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 405623
  --> https://bugs.webkit.org/attachment.cgi?id=405623
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405623&action=review

> Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:721
> +    renameOriginForVersion("v0");

Why would we want to rename v0?  The SPI user of this will only have v1, I
think.

> Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp:101
> +	   postTaskReply(CrossThreadTask([callback = WTFMove(callback)]()
mutable {

Could this be simpler instead of making a lambda just to wrap a
CompletionHandler?
postTaskReply(CrossThreadTask(WTFMove(callback)));

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:561
> +    RetainPtr<WebsiteDataStoreCustomPathsMessageHandler> handler =
adoptNS([[WebsiteDataStoreCustomPathsMessageHandler alloc] init]);

These could use auto.