[webkit-reviews] review denied: [Bug 214990] Added AudioBuffer Constructor : [Attachment 405628] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Clark Wang <clark_wang at apple.com>'s
request for review:
Bug 214990: Added AudioBuffer Constructor
https://bugs.webkit.org/show_bug.cgi?id=214990

Attachment 405628: Patch

https://bugs.webkit.org/attachment.cgi?id=405628&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 405628
  --> https://bugs.webkit.org/attachment.cgi?id=405628
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405628&action=review

> Source/WebCore/Modules/webaudio/AudioBuffer.cpp:55
> +ExceptionOr<Ref<AudioBuffer>> AudioBuffer::create(const AudioBufferOptions&&
options)

no const.

> Source/WebCore/Modules/webaudio/AudioBuffer.cpp:67
> +    if (!buffer->m_length)

I'd rather we use the length() getter.

> Source/WebCore/Modules/webaudio/AudioBuffer.h:45
> +    static ExceptionOr<Ref<AudioBuffer>> create(const AudioBufferOptions&& =
{ });

no const

> Source/WebCore/Modules/webaudio/AudioBufferOptions.h:33
> +    unsigned numberOfChannels;

Please provide default values for these. Otherwise, when you used
AudioBufferOptions { } earlier in your patch as default parameter value, it
constructed a struct with uninitialized members.

> Source/WebCore/Modules/webaudio/AudioBufferOptions.h:34
> +    size_t length;

unsigned

> Source/WebCore/Modules/webaudio/OfflineAudioContextOptions.idl:25
> + 

Unnecessary change.

>
LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuf
fersourcenode-interface/audiobuffersource-channels-expected.txt:9
> +FAIL X source.buffer = new buffer did not throw an exception. assert_true:
expected true got false

This seems bad?

>
LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuf
fersourcenode-interface/audiobuffersource-channels-expected.txt:11
> +FAIL X source.buffer = buffer again did not throw an exception. assert_true:
expected true got false

how about this?