[webkit-reviews] review granted: [Bug 214984] [iPadOS] Two taps are required to choose a country/region when creating an account on ea.com : [Attachment 405613] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 214984: [iPadOS] Two taps are required to choose a country/region when
creating an account on ea.com
https://bugs.webkit.org/show_bug.cgi?id=214984

Attachment 405613: Patch

https://bugs.webkit.org/attachment.cgi?id=405613&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 405613
  --> https://bugs.webkit.org/attachment.cgi?id=405613
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405613&action=review

r=me

> Source/WebKit/UIProcess/ios/forms/WKFormPopover.mm:141
> +	   auto scale = [_view page]->pageScaleFactor();

`_view.page`?

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:25
> +jsTestIsAsync = true;

NIT: `window.jsTestIsAsync = true;`

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:26
> +clickCount = 0;

NIT: `let`

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:28
> +addEventListener("load", async () => {

NIT: `window.addEventListener` or `document.addEventListener`?	I'd put one
just to be clear.

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:36
> +    button = document.querySelector("button");

NIT: `let`

> LayoutTests/fast/forms/ios/repeatedly-focus-offscreen-select.html:37
> +    select = document.querySelector("select");

NIT: `let`