[webkit-reviews] review granted: [Bug 214983] webkitpy: If LC_ALL is set to a empty string, svn doesn't use the password store : [Attachment 405601] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 13:50:40 PDT 2020


Darin Adler <darin at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 214983: webkitpy: If LC_ALL is set to a empty string, svn doesn't use the
password store
https://bugs.webkit.org/show_bug.cgi?id=214983

Attachment 405601: Patch

https://bugs.webkit.org/attachment.cgi?id=405601&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 405601
  --> https://bugs.webkit.org/attachment.cgi?id=405601
Patch

Looks great to me, but I am not sure why we had it set to empty string before.


More information about the webkit-reviews mailing list