[webkit-reviews] review granted: [Bug 214965] [iOS] Issue a temporary extension to the MobileGestalt daemon when the MobileGestalt cache is invalid : [Attachment 405600] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 13:37:00 PDT 2020


Geoffrey Garen <ggaren at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 214965: [iOS] Issue a temporary extension to the MobileGestalt daemon when
the MobileGestalt cache is invalid
https://bugs.webkit.org/show_bug.cgi?id=214965

Attachment 405600: Patch

https://bugs.webkit.org/attachment.cgi?id=405600&action=review




--- Comment #10 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 405600
  --> https://bugs.webkit.org/attachment.cgi?id=405600
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405600&action=review

r=me

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:206
> +	   auto extension =
SandboxExtension::create(WTFMove(*parameters.mobileGestaltExtensionHandle));
> +	   if (extension) {

You can merge these two lines as "if (auto extension = ....)".


More information about the webkit-reviews mailing list