[webkit-reviews] review denied: [Bug 214958] Web Inspector: Hide clipped timeline markers : [Attachment 405549] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 214958: Web Inspector: Hide clipped timeline markers
https://bugs.webkit.org/show_bug.cgi?id=214958

Attachment 405549: Patch

https://bugs.webkit.org/attachment.cgi?id=405549&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 405549
  --> https://bugs.webkit.org/attachment.cgi?id=405549
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405549&action=review

r- due to the issue above

> Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.css:30
> +    overflow: initial;

Does this actually do anything?

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css:135
> +.timeline-ruler > .markers > .marker.before-selection {
> +    display: none;
> +}

Why is this needed?

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:639
> +	       element.classList.toggle("before-selection", newPositionAprox <=
0);

Shouldn't it only be `< 0`?  I think we probably should show the marker if it's
exactly at `0`.