[webkit-reviews] review granted: [Bug 214327] [ iOS ] webanimations/accelerated-animation-with-easing.html is still flaky : [Attachment 405561] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 214327: [ iOS ] webanimations/accelerated-animation-with-easing.html is
still flaky
https://bugs.webkit.org/show_bug.cgi?id=214327

Attachment 405561: Patch

https://bugs.webkit.org/attachment.cgi?id=405561&action=review




--- Comment #6 from Dean Jackson <dino at apple.com> ---
Comment on attachment 405561
  --> https://bugs.webkit.org/attachment.cgi?id=405561
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405561&action=review

> Source/WebKit/ChangeLog:18
> +	   This fixes the test added originally in r263506 which would only
work flakily, a sympton of this

Typo: symptom.

>
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:1
56
> +static void encodeTimingFunction(IPC::Encoder& encoder, TimingFunction*
timingFunction)

I think these methods should go in WebCoreArgumentCoders.

>
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:2
39
> +	   encodeTimingFunction(encoder, timingFunction.get());

Which would just make this

encoder << timingFunction.get();