[webkit-reviews] review granted: [Bug 214971] Use more inclusive terminology in Tools : [Attachment 405582] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 10:03:44 PDT 2020


Sam Weinig <sam at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 214971: Use more inclusive terminology in Tools
https://bugs.webkit.org/show_bug.cgi?id=214971

Attachment 405582: patch

https://bugs.webkit.org/attachment.cgi?id=405582&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 405582
  --> https://bugs.webkit.org/attachment.cgi?id=405582
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405582&action=review

> LayoutTests/ChangeLog:21
> +	   * http/tests/xmlhttprequest/origin-whitelisting-all.html:
> +	   * http/tests/xmlhttprequest/origin-whitelisting-exact-match.html:
> +	   * http/tests/xmlhttprequest/origin-whitelisting-https.html:
> +	   *
http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html
:
> +	   * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html:
> +	   * http/tests/xmlhttprequest/origin-whitelisting-removal.html:
> +	   * http/tests/xmlhttprequest/origin-whitelisting-subdomains.html:

Probably worth renaming the tests while you are doing this.


More information about the webkit-reviews mailing list