[webkit-reviews] review granted: [Bug 214962] Web content gets stuck in an inactive state (no cursor updates or text insertion caret) when activating a tab with a thumbnail visible : [Attachment 405560] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 08:02:48 PDT 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 214962: Web content gets stuck in an inactive state (no cursor updates or
text insertion caret) when activating a tab with a thumbnail visible
https://bugs.webkit.org/show_bug.cgi?id=214962

Attachment 405560: Patch

https://bugs.webkit.org/attachment.cgi?id=405560&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 405560
  --> https://bugs.webkit.org/attachment.cgi?id=405560
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405560&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3859
> +	   m_page->activityStateDidChange(WebCore::ActivityState::allFlags());

Nit - is there value in being more specific than `allFlags()` here?


More information about the webkit-reviews mailing list