[webkit-reviews] review requested: [Bug 214951] [webkitpy] Use webkitcorepy's auto installer for requests : [Attachment 405545] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has asked  for review:
Bug 214951: [webkitpy] Use webkitcorepy's auto installer for requests
https://bugs.webkit.org/show_bug.cgi?id=214951

Attachment 405545: Patch

https://bugs.webkit.org/attachment.cgi?id=405545&action=review




--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 405545
  --> https://bugs.webkit.org/attachment.cgi?id=405545
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405545&action=review

> Tools/Scripts/webkitpy/thirdparty/__init__.py:86
> +	       sys.path.insert(1 if 'libraries/autoinstalled' in sys.path[0]
else 0, _AUTOINSTALLED_DIR)

Needed for compatibility. webkitpy cannot override webkitcorepy since
webkitcorepy is, in some cases, uses more updated versions of the
auto-installed libraries. We also don't want to require existing checkouts to
delete their webkitpy auto install directory.