[webkit-reviews] review granted: [Bug 214938] Highlight color does not switch after being set it system preferences. : [Attachment 405508] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 29 15:09:31 PDT 2020


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 214938: Highlight color does not switch after being set it system
preferences.
https://bugs.webkit.org/show_bug.cgi?id=214938

Attachment 405508: Patch

https://bugs.webkit.org/attachment.cgi?id=405508&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 405508
  --> https://bugs.webkit.org/attachment.cgi?id=405508
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405508&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:933
> +static const WTF::String& userHighlightColorPreferenceKey()

Space above here.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:938
> +

Not here.


More information about the webkit-reviews mailing list