[webkit-reviews] review granted: [Bug 214938] Highlight color does not switch after being set it system preferences. : [Attachment 405507] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 214938: Highlight color does not switch after being set it system
preferences.
https://bugs.webkit.org/show_bug.cgi?id=214938

Attachment 405507: Patch

https://bugs.webkit.org/attachment.cgi?id=405507&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 405507
  --> https://bugs.webkit.org/attachment.cgi?id=405507
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405507&action=review

> Source/WebKit/ChangeLog:9
> +	   After the changes to the sandbox and how defaults are being
transferred to the web process,

This should probably reference a commit.

> Source/WebKit/ChangeLog:11
> +	   after setting the defaults so that the value is retried after it is
actually set and we do

"value is retried" -> "cache is invalidated"

You might even mention which cache (colorCache in RenderTheme)...

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:953
> +	   [notificationCenter
postNotificationName:@"NSSystemColorsWillChangeNotification" object:nil];
> +	   [notificationCenter
postNotificationName:NSSystemColorsDidChangeNotification object:nil];

While it looks weird that "WillChange" and "DidChange" are adjacent without the
change sitting between them, this does match what happens in AppKit.