[webkit-reviews] review granted: [Bug 214931] Calling AudioNode constructors should have identical behavior than using create*() function on BaseAudioContext : [Attachment 405486] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 29 13:07:37 PDT 2020
Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 214931: Calling AudioNode constructors should have identical behavior than
using create*() function on BaseAudioContext
https://bugs.webkit.org/show_bug.cgi?id=214931
Attachment 405486: Patch
https://bugs.webkit.org/attachment.cgi?id=405486&action=review
--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 405486
--> https://bugs.webkit.org/attachment.cgi?id=405486
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=405486&action=review
> Source/WebCore/ChangeLog:3
> + Calling AudioNode constructors should have identical behavior than
using create*() function on BaseAudioContext
s/identical behavior than using create/identical behavior to using create/
> Source/WebCore/ChangeLog:8
> + Calling AudioNode constructors should have identical behavior than
using create*() function on BaseAudioContext.
Ditto.
More information about the webkit-reviews
mailing list