[webkit-reviews] review granted: [Bug 214928] Support HDR decode in SW VP9 : [Attachment 405480] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 214928: Support HDR decode in SW VP9
https://bugs.webkit.org/show_bug.cgi?id=214928

Attachment 405480: Patch

https://bugs.webkit.org/attachment.cgi?id=405480&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 405480
  --> https://bugs.webkit.org/attachment.cgi?id=405480
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405480&action=review

r=me once the bots are happy

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:277
> +	   CFTypeRef configurationRecord =
CFDictionaryGetValue((CFDictionaryRef)extensionAtoms, CFSTR("vpcC"));

`auto configurationRecord = static_cast<CFDataRef>(CFDictionaryGetValue(...`

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:281
> +	   auto configurationRecordSize =
CFDataGetLength((CFDataRef)configurationRecord);

The cast isn't necessary with the above.

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:285
> +	   auto configurationRecordData =
CFDataGetBytePtr((CFDataRef)configurationRecord);

Ditto

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:305
> +	   CFMutableArrayRef cfPixelFormats =
CFArrayCreateMutable(kCFAllocatorDefault, 2, &kCFTypeArrayCallBacks);

'auto cfPixelFormats = ...`

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:310
> +	   CFNumberRef borderPixelsValue = createNumber(32);

`auto borderPixelsValue = ...`

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:326
> +	   CFDictionaryRef attributes = CFDictionaryCreate(kCFAllocatorDefault,
keys, values, std::size(keys), &kCFTypeDictionaryKeyCallBacks,
&kCFTypeDictionaryValueCallBacks);

`auto attributes = ...`

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:342
> +    CFRelease(pixelBufferAttributes);

Double release!