[webkit-reviews] review granted: [Bug 214925] Make sure playback state constants remain on OscillatorNode for backward compatibility : [Attachment 405474] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 29 10:57:05 PDT 2020


Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 214925: Make sure playback state constants remain on OscillatorNode for
backward compatibility
https://bugs.webkit.org/show_bug.cgi?id=214925

Attachment 405474: Patch

https://bugs.webkit.org/attachment.cgi?id=405474&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 405474
  --> https://bugs.webkit.org/attachment.cgi?id=405474
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405474&action=review

> Source/WebCore/Modules/webaudio/OscillatorNode.idl:41
> +    // Legacy Playback state constants kept for backward compatibility with
the prefixed API.

You may want to add a comment that these will be removed at some point.


More information about the webkit-reviews mailing list