[webkit-reviews] review granted: [Bug 214923] [ews.webkit.org] Skip build upload for embedded iOS builds : [Attachment 405468] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 29 10:06:28 PDT 2020


Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 214923: [ews.webkit.org] Skip build upload for embedded iOS builds
https://bugs.webkit.org/show_bug.cgi?id=214923

Attachment 405468: Patch

https://bugs.webkit.org/attachment.cgi?id=405468&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 405468
  --> https://bugs.webkit.org/attachment.cgi?id=405468
Patch

would be good to add a unit-test as well in
factories_unittest.py::TestBuildFactory similar to test_ios_build_factory


More information about the webkit-reviews mailing list