[webkit-reviews] review granted: [Bug 214907] REGRESSION(r264476): Calling systemHasAC() regresses launch time performance : [Attachment 405434] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 214907: REGRESSION(r264476): Calling systemHasAC() regresses launch time
performance
https://bugs.webkit.org/show_bug.cgi?id=214907

Attachment 405434: Patch

https://bugs.webkit.org/attachment.cgi?id=405434&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 405434
  --> https://bugs.webkit.org/attachment.cgi?id=405434
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405434&action=review

> Source/WebCore/platform/cocoa/PowerSourceNotifier.mm:44
>      if (status == NOTIFY_STATUS_OK)
>	   m_tokenID = token;

If notify_register_dispatch failed, should this just return early instead of
potentially calling notifyPowerSourceChanged()?