[webkit-reviews] review granted: [Bug 214825] Remember to check entitlement before communicating over XPC : [Attachment 405453] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 29 08:33:13 PDT 2020


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 214825: Remember to check entitlement before communicating over XPC
https://bugs.webkit.org/show_bug.cgi?id=214825

Attachment 405453: Patch

https://bugs.webkit.org/attachment.cgi?id=405453&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 405453
  --> https://bugs.webkit.org/attachment.cgi?id=405453
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405453&action=review

R=me

> Source/WebKit/Shared/Cocoa/XPCEndpoint.mm:47
> +		   WTFLogAlways("Audit token does not have required
entitlement");

Should we just say what entitlement in the error message?


More information about the webkit-reviews mailing list