[webkit-reviews] review granted: [Bug 214902] Move non standard OscillatorNode API to new webKitOscillatorNode interface : [Attachment 405428] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 28 17:19:33 PDT 2020


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 214902: Move non standard OscillatorNode API to new webKitOscillatorNode
interface
https://bugs.webkit.org/show_bug.cgi?id=214902

Attachment 405428: Patch

https://bugs.webkit.org/attachment.cgi?id=405428&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 405428
  --> https://bugs.webkit.org/attachment.cgi?id=405428
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405428&action=review

> Source/WebCore/Modules/webaudio/WebKitOscillatorNode.h:32
> +class WebKitOscillatorNode : public OscillatorNode {

final

> Source/WebCore/Modules/webaudio/WebKitOscillatorNode.h:46
> +    const char* activeDOMObjectName() const final { return
"WebKitOscillatorNode"; }

private


More information about the webkit-reviews mailing list