[webkit-reviews] review granted: [Bug 214889] Migrate App-Bound Domains code from WebKit Additions : [Attachment 405419] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 28 15:33:06 PDT 2020


Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 214889: Migrate App-Bound Domains code from WebKit Additions
https://bugs.webkit.org/show_bug.cgi?id=214889

Attachment 405419: Patch

https://bugs.webkit.org/attachment.cgi?id=405419&action=review




--- Comment #12 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 405419
  --> https://bugs.webkit.org/attachment.cgi?id=405419
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405419&action=review

r=me, but please correct the ChangeLog that includes Ryan's description, too.

> Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:192
> +	   @"NSRemindersUsageDescription",

Can you please remove the "NSRemindersUsageDescription", we are not restricting
this one anymore.

> LayoutTests/ChangeLog:11
> +

Oops! Two ChangeLog entries.


More information about the webkit-reviews mailing list