[webkit-reviews] review granted: [Bug 214860] [EventSource] WebKit fails to UTF-8 encode the Last-Event-ID HTTP header value : [Attachment 405397] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 214860: [EventSource] WebKit fails to UTF-8 encode the Last-Event-ID HTTP
header value
https://bugs.webkit.org/show_bug.cgi?id=214860

Attachment 405397: Patch

https://bugs.webkit.org/attachment.cgi?id=405397&action=review




--- Comment #14 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 405397
  --> https://bugs.webkit.org/attachment.cgi?id=405397
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405397&action=review

> Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:198
> +	   [nsRequest setValue:encodedValue.bridgingAutorelease()
forHTTPHeaderField:header.key];

This will cause a spike in the autoreleasepool size.  Why not just
encodedValue.get()?  Then it's immediately released after use.