[webkit-reviews] review granted: [Bug 214886] Web Inspector: Don't allow docking to a hidden web view : [Attachment 405380] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 214886: Web Inspector: Don't allow docking to a hidden web view
https://bugs.webkit.org/show_bug.cgi?id=214886

Attachment 405380: Patch

https://bugs.webkit.org/attachment.cgi?id=405380&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 405380
  --> https://bugs.webkit.org/attachment.cgi?id=405380
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405380&action=review

r=me

> Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp:282
> +    if (!m_inspectedPage || !m_inspectorPage ||
!platformCanAttach(m_canAttach))

NIT: can you use `platformCanAttach(canAttach())` instead?  This is what other
callers do, and it covers the future case where `canAttach` becomes more
complex :)

> Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp:314
> +    if (!m_inspectedPage || !m_inspectorPage || (!m_isAttached &&
m_isVisible))

Is `m_isVisible` necessary?