[webkit-reviews] review granted: [Bug 214879] [Big Sur] Add Seed 3 builder : [Attachment 405376] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 214879: [Big Sur] Add Seed 3 builder
https://bugs.webkit.org/show_bug.cgi?id=214879

Attachment 405376: Patch

https://bugs.webkit.org/attachment.cgi?id=405376&action=review




--- Comment #6 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 405376
  --> https://bugs.webkit.org/attachment.cgi?id=405376
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405376&action=review

r+ with comments.

> Tools/ChangeLog:3
> +	   [Big Sur] Add Seed 3 builder

A better bug title might be: [build.webkit.org] Add Big Sur builder.
The patch isn't specific to seed 3, 'seed 3' is a minor implementation detail.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:4
> +		       { "name": "bot279", "platform": "mac-bigsur"},

Might consider adding one more bot in the config right away, even if it would
be ready after a while. One bot might not be enough for this queue.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:109
> +			 "triggers": [],

triggers can be removed from here.