[webkit-reviews] review granted: [Bug 214867] Add WebRTC tests exercising H264 with various resolutions and bitrates. : [Attachment 405353] Patch

Tue Jul 28 09:28:58 PDT 2020

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 214867: Add WebRTC tests exercising H264 with various resolutions and
bitrates.
https://bugs.webkit.org/show_bug.cgi?id=214867

Attachment 405353: Patch

https://bugs.webkit.org/attachment.cgi?id=405353&action=review

--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 405353
  --> https://bugs.webkit.org/attachment.cgi?id=405353
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405353&action=review

>
LayoutTests/http/wpt/fetch/readableStreamDefaultController-overwriting-expected
.txt:5
> +
> +PASS Overwrite ReadableStreamDefaultController enqueue 
> +PASS Overwrite ReadableStreamDefaultController error 
> +PASS Overwrite ReadableStreamDefaultController close 
> +

I don't think you meant to include this.

>
LayoutTests/http/wpt/fetch/readableStreamDefaultController-overwriting.html:11
> +<!DOCTYPE html>
> +<script src='/resources/testharness.js'></script>
> +<script src='/resources/testharnessreport.js'></script>
> +<script>
> +
> +var controllerPrototype;
> +const rs = new ReadableStream({
> +    start: function(c) {
> +	   controllerPrototype = Object.getPrototypeOf(c);
> +    }
> +});

Ditto

> LayoutTests/http/wpt/fetch/resources/lengthy-pass.py:7
> +import time
> +
> +def main(request, response):
> +    delay = 0.05
> +    headers = []
> +    if "delay" in request.GET:
> +	   delay = float(request.GET.first("delay"))

Ditto.