[webkit-reviews] review granted: [Bug 214837] ASSERTION FAILED: isSymbol() in Source/JavaScriptCore/runtime/JSCell.cpp(188) : [Attachment 405339] proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 28 09:13:03 PDT 2020
Darin Adler <darin at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 214837: ASSERTION FAILED: isSymbol() in
Source/JavaScriptCore/runtime/JSCell.cpp(188)
https://bugs.webkit.org/show_bug.cgi?id=214837
Attachment 405339: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=405339&action=review
--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 405339
--> https://bugs.webkit.org/attachment.cgi?id=405339
proposed patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=405339&action=review
> Source/JavaScriptCore/jsc.cpp:477
> + static constexpr unsigned DontEnum = 0 | PropertyAttribute::DontEnum;
What is the purpose of the "0 |" here? Is it a way to convert an enumeration
value to an integer? Why is it better than static_cast?
More information about the webkit-reviews
mailing list