[webkit-reviews] review granted: [Bug 209216] PerformanceObserver should work with 'type' and not just `entryTypes` : [Attachment 405301] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 209216: PerformanceObserver should work with 'type' and not just
`entryTypes`
https://bugs.webkit.org/show_bug.cgi?id=209216

Attachment 405301: Patch

https://bugs.webkit.org/attachment.cgi?id=405301&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 405301
  --> https://bugs.webkit.org/attachment.cgi?id=405301
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405301&action=review

> Source/WebCore/page/PerformanceObserver.cpp:68
> +	   for (const String& entryType : *init.entryTypes) {

const auto&

> Source/WebCore/page/PerformanceObserver.cpp:-74
> -

You could replace the two above if by:
if (filter.isEmpty())
    return { };
That would allow to remove validEntryTypes for instance.

>
LayoutTests/imported/w3c/web-platform-tests/resource-timing/buffered-flag.any.w
orker-expected.txt:2
> +Harness Error (TIMEOUT), message = null

Do you know why all these tests are timing out?
Since they are timing out, we should probably skip them in TestExpectations.