[webkit-reviews] review granted: [Bug 214786] Add null checks in ResourceLoader : [Attachment 405343] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 214786: Add null checks in ResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=214786

Attachment 405343: Patch

https://bugs.webkit.org/attachment.cgi?id=405343&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 405343
  --> https://bugs.webkit.org/attachment.cgi?id=405343
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405343&action=review

> Source/WebCore/ChangeLog:12
> +	   The original patch for this has a test that would reach this code,
but it never finishes loading.

Can we do an API test and use a timer to conclude the test (and verify it does
not hit some debug assert for instance)?

> Source/WebCore/loader/ResourceLoader.cpp:126
> +    if (!m_documentLoader || !m_documentLoader->frame()) {

Can we keep ASSERT(m_documentLoader)?