[webkit-reviews] review granted: [Bug 214707] Remove definition of NSImageSymbolScale, which is part of the beta 3 SDK : [Attachment 405109] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 27 12:57:14 PDT 2020


Jonathan Bedard <jbedard at apple.com> has granted Saagar Jha
<saagar at saagarjha.com>'s request for review:
Bug 214707: Remove definition of NSImageSymbolScale, which is part of the beta
3 SDK
https://bugs.webkit.org/show_bug.cgi?id=214707

Attachment 405109: Patch

https://bugs.webkit.org/attachment.cgi?id=405109&action=review




--- Comment #9 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 405109
  --> https://bugs.webkit.org/attachment.cgi?id=405109
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405109&action=review

>> Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h:39
>>  extern const NSImageHintKey NSImageHintSymbolScale;
> 
> Are these still not part of SDK, even though NSImageSymbolScale is?

Verified that these are not part of the SDK.

>> Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h:42
>>  - (void)lockFocusWithRect:(NSRect)rect context:(nullable NSGraphicsContext
*)context hints:(nullable NSDictionary *)hints flipped:(BOOL)flipped;
> 
> Not seeing an underscore makes me wonder if this is SDK too.

That actually pre-dates Big Sur. And yes, it's still required.


More information about the webkit-reviews mailing list