[webkit-reviews] review granted: [Bug 214830] Disable low latency code path for H264 constrained baseline : [Attachment 405281] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 214830: Disable low latency code path for H264 constrained baseline
https://bugs.webkit.org/show_bug.cgi?id=214830

Attachment 405281: Patch

https://bugs.webkit.org/attachment.cgi?id=405281&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 405281
  --> https://bugs.webkit.org/attachment.cgi?id=405281
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405281&action=review

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVi
deoEncoderH264.mm:757
> +    CFBooleanRef hwaccl_enabled = nullptr;
> +    if (status == noErr) {
> +	 status = VTSessionCopyProperty(_vtCompressionSession,
> +				 
kVTCompressionPropertyKey_UsingHardwareAcceleratedVideoEncoder,
> +				  nullptr,
> +				  &hwaccl_enabled);
> +    }

I see that this is copied from RTCVideoEncoderH264 and RTCVideoEncoderH265 so
it isn't new, but doesn't this leak the CFBooleanRef?