[webkit-reviews] review granted: [Bug 214746] Added Constructor method to OscillatorNode : [Attachment 405288] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Clark Wang <clark_wang at apple.com>'s
request for review:
Bug 214746: Added Constructor method to OscillatorNode
https://bugs.webkit.org/show_bug.cgi?id=214746

Attachment 405288: Patch

https://bugs.webkit.org/attachment.cgi?id=405288&action=review




--- Comment #18 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 405288
  --> https://bugs.webkit.org/attachment.cgi?id=405288
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405288&action=review

> Source/WebCore/Modules/webaudio/OscillatorNode.cpp:-70
> -    // An oscillator is always mono.

I would keep this comment.

> Source/WebCore/Modules/webaudio/OscillatorNode.h:56
> +    OscillatorNode(BaseAudioContext&, const OscillatorOptions& = { });

explicit

> Source/WebCore/Modules/webaudio/OscillatorOptions.h:32
> +#include "PeriodicWave.h"

Can this be forward-declared?