[webkit-reviews] review granted: [Bug 214344] [GTK4] Enable API tests : [Attachment 404327] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 27 02:35:29 PDT 2020
Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 214344: [GTK4] Enable API tests
https://bugs.webkit.org/show_bug.cgi?id=214344
Attachment 404327: Patch
https://bugs.webkit.org/attachment.cgi?id=404327&action=review
--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 404327
--> https://bugs.webkit.org/attachment.cgi?id=404327
Patch
Looks fine, I have written a few comments below which you may want to
check before landing :)
View in context: https://bugs.webkit.org/attachment.cgi?id=404327&action=review
> Tools/TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:97
> + GMainLoop* loop = g_main_loop_new(nullptr, TRUE);
This never gets freed, I would use “GRefPtr<GMainLoop>” here here to avoid a
false positive when using Valgrind (or any other tools) to find leaks. Or use
“g_autoptr(GMainLoop)”, or a plain “g_clear_pointer(&loop, g_main_loop_unref)”.
> Tools/TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:48
> + GMainLoop *loop = g_main_loop_new(nullptr, TRUE);
Same here.
> Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:667
> #if USE(GTK4)
Why not remove the “#if” block completely? If the idea is to keep the comment
below for when the tests disabled for GTK4 are brought back then I think it is
okay to leave it around.
> Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:278
> + m_inspectorWindow = nullptr;
Probably I would move the “m_inspectorWindow = nullptr;” line out of the
#if-#endif block, because it's repeated in both cases; but I do not have
a strong opinion on this—feel free to leave it as-is if you think it's more
legible.
More information about the webkit-reviews
mailing list