[webkit-reviews] review granted: [Bug 193671] Scroll Snap broken when using RTL layout : [Attachment 405241] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 193671: Scroll Snap broken when using RTL layout
https://bugs.webkit.org/show_bug.cgi?id=193671

Attachment 405241: Patch

https://bugs.webkit.org/attachment.cgi?id=405241&action=review




--- Comment #10 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 405241
  --> https://bugs.webkit.org/attachment.cgi?id=405241
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405241&action=review

> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp:59
> +static LayoutUnit computeScrollSnapAlignOffset(LayoutUnit minLocation,
LayoutUnit maxLocation, ScrollSnapAxisAlignType alignment, bool isRTL)

Nit - it seems a bit confusing that isRTL is false when computing offsets in
the y-axis, even though we could be in RTL. What do you think about
`isFlipped`, or `startsAtMaxLocation`?