[webkit-reviews] review granted: [Bug 214807] [Cocoa] Make DecoderTest run against .mp4 files; add rate-limiting. : [Attachment 405255] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 214807: [Cocoa] Make DecoderTest run against .mp4 files; add rate-limiting.
https://bugs.webkit.org/show_bug.cgi?id=214807

Attachment 405255: Patch

https://bugs.webkit.org/attachment.cgi?id=405255&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 405255
  --> https://bugs.webkit.org/attachment.cgi?id=405255
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405255&action=review

> Source/WebCore/ChangeLog:16
> +	   * platform/graphics/cocoa/VP9UtilitiesCocoa.h:
> +	   * platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
> +	   (WebCore::registerWebKitVP9Decoder):

I would have left the word "utilities" out of this file’s name.

> Source/WebCore/SourcesCocoa.txt:359
> +platform/graphics/cocoa/VP9UtilitiesCocoa.mm @no-unify

Is this *really* necessary? Why?