[webkit-reviews] review granted: [Bug 214555] pluginElementCustomGetOwnPropertySlot() should support VMInquiry requests. : [Attachment 405221] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 214555: pluginElementCustomGetOwnPropertySlot() should support VMInquiry
requests.
https://bugs.webkit.org/show_bug.cgi?id=214555

Attachment 405221: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=405221&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 405221
  --> https://bugs.webkit.org/attachment.cgi?id=405221
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=405221&action=review

r=me

> Source/JavaScriptCore/runtime/JSObjectInlines.h:136
> +	   if (slot.isVMInquiry() && slot.isTaintedByOpaqueObject())

Let's put `UNLIKELY`.

> Source/JavaScriptCore/runtime/JSObjectInlines.h:179
> +	       if (slot.isVMInquiry() && slot.isTaintedByOpaqueObject())

Let's put UNLIKELY