[webkit-reviews] review denied: [Bug 214771] WebCoreResourceHandleAsOperationQueueDelegate can use RunLoop::dispatch : [Attachment 405207] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 214771: WebCoreResourceHandleAsOperationQueueDelegate can use
RunLoop::dispatch
https://bugs.webkit.org/show_bug.cgi?id=214771

Attachment 405207: Patch

https://bugs.webkit.org/attachment.cgi?id=405207&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 405207
  --> https://bugs.webkit.org/attachment.cgi?id=405207
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405207&action=review

The code in WebCoreResourceHandleAsOperationQueueDelegate.mm took several
iterations to get just right, and I don't think the code in WTF is equivalent. 
Could you include a radar with a list of clients?

> Source/WTF/wtf/cf/RunLoopCF.cpp:91
> +	   if (schedulePair->mode() == kCFRunLoopCommonModes

What about kCFRunLoopDefaultMode?